Repository navigation
chore(deps): update launchdarkly/gh-actions requirement to release-secrets-v1.2.2 in /.github/actions/full-release - #424
Conversation
…crets-v1.2.2 Updates the requirements on [launchdarkly/gh-actions](https://github.com/launchdarkly/gh-actions) to permit the latest version. - [Release notes](https://github.com/launchdarkly/gh-actions/releases) - [Commits](https://github.com/launchdarkly/gh-actions/commits/release-secrets-v1.2.2) --- updated-dependencies: - dependency-name: launchdarkly/gh-actions dependency-version: 1.2.2 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit de673b9. Configure here.
|
|
||
| - name: Sign DLLs | ||
| uses: launchdarkly/gh-actions/actions/sign-dlls@sign-dlls-v1.0.0 | ||
| uses: launchdarkly/gh-actions/actions/sign-dlls@release-secrets-v1.2.2 |
There was a problem hiding this comment.
Wrong tag pins sign-dlls action
High Severity
The sign-dlls step is now pinned to release-secrets-v1.2.2 instead of a sign-dlls-* tag. That ref belongs to a different action in the same repo, so this step runs an unintended revision of sign-dlls and can break DLL signing on release.
Reviewed by Cursor Bugbot for commit de673b9. Configure here.
There was a problem hiding this comment.
Risk: high.
Automated risk review (dry run): High
This PR would not be automatically approved. Human approval required.
Why: .github/actions/full-release/action.yml is release/CI infrastructure (secrets fetch and DLL signing), which is never Low; Dependabot also retargeted sign-dlls from sign-dlls-v1.0.0 to release-secrets-v1.2.2, and Bugbot left an unresolved high-severity finding on that pin.
If you disagree with this review, share this PR in #feedback-agent-approvals or submit a changes-requested review explaining why.
Sent by Cursor Approval Agent: Dry-Run PR Approver
jsonbailey
left a comment
There was a problem hiding this comment.
Do not merge. This PR sets an invalid ref for launchdarkly/gh-actions:
sign-dlls@release-secrets-v1.2.2: the tag is for a different action
Dependabot treats all actions in launchdarkly/gh-actions as one dependency, because the tags use a dash between the action name and the version. It then moves every ref to the newest tag in the repo, even when that tag belongs to another action. The fix is in launchdarkly/gh-actions#137.




Updates the requirements on launchdarkly/gh-actions to permit the latest version.
Release notes
Sourced from launchdarkly/gh-actions's releases.
Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)Note
Overview
Bumps the Get secrets step in
full-releasefromrelease-secrets-v1.2.1torelease-secrets-v1.2.2(dependency bumps in that action per release notes).The Sign DLLs step is also changed from
sign-dlls@sign-dlls-v1.0.0tosign-dlls@release-secrets-v1.2.2—same tag as release-secrets, not asign-dlls-*ref—whereas other workflows (e.g.release-sdk-client) still usesign-dlls-v1.0.0.Reviewed by Cursor Bugbot for commit de673b9. Bugbot is set up for automated code reviews on this repo. Configure here.